Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ertp): durability #5283

Merged
merged 1 commit into from
Jul 8, 2022
Merged

feat(ertp): durability #5283

merged 1 commit into from
Jul 8, 2022

Conversation

erights
Copy link
Member

@erights erights commented May 4, 2022

Make ERTP Durable

@erights erights requested a review from FUDCo May 4, 2022 06:29
@erights erights self-assigned this May 4, 2022
turadg
turadg reviewed May 4, 2022
View reviewed changes
packages/ERTP/src/brand.js Outdated Show resolved Hide resolved
packages/ERTP/src/brand.js Outdated Show resolved Hide resolved
packages/ERTP/src/issuerKit.js Show resolved Hide resolved
packages/store/src/stores/store-utils.js Outdated Show resolved Hide resolved
packages/ERTP/src/paymentLedger.js Outdated Show resolved Hide resolved
Base automatically changed from markm-store-provide to master May 4, 2022 19:23
@erights erights force-pushed the markm-durable-ertp branch 2 times, most recently from 6cc2d43 to b97d552 Compare May 10, 2022 03:01
@Chris-Hibbert Chris-Hibbert mentioned this pull request May 10, 2022
Closed
FUDCo added a commit that referenced this pull request May 11, 2022
@FUDCo
fix: bug in fake virtual stuff due to recent liveslots additions
51c90b9 
In support of #5283.

@erights and @Chris-Hibbert encountered this in the course of testing their
durabilization of ERTP.  Note that this bug only implicates tests and not the
actual underlying virtual objects implementation.
@FUDCo FUDCo mentioned this pull request May 11, 2022
Merged
FUDCo added a commit that referenced this pull request May 11, 2022
@FUDCo
fix: bug in fake virtual stuff due to recent liveslots additions
db71bd7 
In support of #5283.

@erights and @Chris-Hibbert encountered this in the course of testing their
durabilization of ERTP.  Note that this bug only implicates tests and not the
actual underlying virtual objects implementation.
@erights erights force-pushed the markm-durable-ertp branch 2 times, most recently from b0b055a to ab82555 Compare May 13, 2022 02:53
@Chris-Hibbert Chris-Hibbert force-pushed the markm-durable-ertp branch 4 times, most recently from 1ef34af to 0077690 Compare May 19, 2022 22:34
@Chris-Hibbert Chris-Hibbert mentioned this pull request May 19, 2022
Merged
@Chris-Hibbert Chris-Hibbert force-pushed the markm-durable-ertp branch 2 times, most recently from fb9fe3d to 630434e Compare May 21, 2022 00:08
@erights erights changed the base branch from master to decodeToJustin May 21, 2022 02:00
erights added a commit that referenced this pull request May 21, 2022
@erights
fix: add straggler change from #5283
29c687a
erights added a commit that referenced this pull request May 21, 2022
@erights
fix: add straggler change from #5283
ae931b8
turadg
turadg reviewed Jun 29, 2022
View reviewed changes
packages/ERTP/src/issuerKit.js Outdated Show resolved Hide resolved
packages/ERTP/src/issuerKit.js Outdated Show resolved Hide resolved
packages/ERTP/test/swingsetTests/ertpService/vat-ertp-service.js Outdated Show resolved Hide resolved
packages/ERTP/src/issuerKit.js Outdated Show resolved Hide resolved
packages/ERTP/src/issuerKit.js Outdated Show resolved Hide resolved
packages/vat-data/src/kind-utils.js Outdated Show resolved Hide resolved
packages/vat-data/src/kind-utils.js Outdated Show resolved Hide resolved
packages/vat-data/src/types.d.ts Show resolved Hide resolved
packages/zoe/src/makeHandle.js Outdated Show resolved Hide resolved
packages/zoe/src/makeHandle.js Show resolved Hide resolved
@erights erights force-pushed the markm-durable-ertp branch 3 times, most recently from d2ad04b to da2b250 Compare July 3, 2022 19:47
@erights
Copy link
Member Author

erights commented Jul 7, 2022

@FUDCo please review at least the SwingSet portion of this PR. Thanks.

FUDCo
FUDCo reviewed Jul 7, 2022
View reviewed changes
Copy link
Contributor

@FUDCo FUDCo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W.r.t the changes to SwingSet: Much of it is tweaks dealing with error message censorship, which is always a pain, and my take on these is pretty much "yeah, whatever". I'm not convinced that the error censorship stuff is adding more value than it subtracts but it's not time to litigate that now.

I do have some serious misgivings about isDurableObject (see comment).

packages/SwingSet/src/liveslots/liveslots.js Show resolved Hide resolved
packages/SwingSet/src/liveslots/virtualObjectManager.js Outdated Show resolved Hide resolved
@erights erights force-pushed the markm-durable-ertp branch 4 times, most recently from 6162bdc to e5c1e75 Compare July 7, 2022 23:40
@erights
Copy link
Member Author

erights commented Jul 8, 2022

@turadg PTAL, including the typing conversation I left open above.

@FUDCo Did I resolve all your concerns adequately to move forward with this PR?

turadg
turadg approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some non-blocking suggestions.

packages/ERTP/src/issuerKit.js Show resolved Hide resolved
packages/vat-data/src/kind-utils.js Outdated Show resolved Hide resolved
packages/vat-data/src/types.d.ts Outdated Show resolved Hide resolved
@erights erights changed the title Make ERTP durable feat(ertp): durability Jul 8, 2022
@erights erights added automerge:squash Automatically squash merge and removed automerge:squash Automatically squash merge labels Jul 8, 2022
@erights erights added automerge:squash Automatically squash merge and removed automerge:squash Automatically squash merge labels Jul 8, 2022
@mergify mergify bot merged commit eab27e4 into master Jul 8, 2022
@mergify mergify bot deleted the markm-durable-ertp branch July 8, 2022 23:05
@dckc dckc mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chris-Hibbert Chris-Hibbert Chris-Hibbert left review comments

@FUDCo FUDCo FUDCo left review comments

@dckc dckc dckc left review comments

@turadg turadg turadg approved these changes

@warner warner Awaiting requested review from warner

@dtribble dtribble Awaiting requested review from dtribble

Assignees

@erights erights

@Chris-Hibbert Chris-Hibbert

Labels
automerge:squash Automatically squash merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erights @turadg @dckc @FUDCo @Chris-Hibbert